Error status not always an integer, sometimes a string

[jstayton]

Most (all?) of the errors produced by the library itself have an integer status. For example,

client.getSource({
  index: 'my_index',
  type: 'my_type',
  id: 'not_found'
})
.catch(function(error) {
  console.log(error.status);
});

outputs the integer 404.

When creating an error directly, however, it's a string. For example,

var errors = require('elasticsearch').errors;
var notFound = new errors.NotFound();

console.log(notFound.status);

outputs the string '404'.

Not a big deal, but it is somewhat annoying when you're doing something like error.status === 404.

[spalger]

Good point

[spalger]

Closed by 0e3fe15

Will release soon

[jstayton]

Thanks! 👍