You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Maybe I'm missing something, but why does this package depend on guzzlehttp/guzzle while elastic/transport can support any PSR client?
The text was updated successfully, but these errors were encountered:
ruudk
changed the title
Why require guzzlehttp/guzzle while elastic/transport is client agnostic
Why require guzzlehttp/guzzle while elastic/transport is client agnostic?
Jul 6, 2023
We decided to simplifying the usage of this library offering a default client, and we choose Guzzle. If you want, you can change the HTTP client using the setHttpClient() function of the client builder, here the documentation.
I understand, but the fact that you require it as a dependency doesn't make sense to me. I think that you want to improve the Developer Experience to automatically require it, but people that pull in this dependency know how to also require a suggested HTTP client. It should be in suggests so that people can freely choose without pulling in Guzzle. I hope you can reconsider it ☺️
@ruudk thanks for your feedback, I agree from a technical point of view but from a product perspective this simplify the process. The majority of the users use guzzle. The only disadvantage is having guzzle installed even if you don't use it, and this is a rare case. That said, we can reconsider it in the next major release if the user scenarios and requirements will change.
Summary of problem or feature request
Maybe I'm missing something, but why does this package depend on
guzzlehttp/guzzle
whileelastic/transport
can support any PSR client?The text was updated successfully, but these errors were encountered: