Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

retry_on_conflict not getting passed to update #2362

Closed
lizzzp1 opened this issue Apr 24, 2024 · 1 comment
Closed

retry_on_conflict not getting passed to update #2362

lizzzp1 opened this issue Apr 24, 2024 · 1 comment
Labels

Comments

@lizzzp1
Copy link

lizzzp1 commented Apr 24, 2024

Hello,

I'm using searchkick and passing a client_option of retry_on_conflict which I would like to be included in any update requests when partial reindexing. Searchkick passes it on the underlying client, but I don't see it being applied when I make _bulk requests.

I know I'm simultaneously asking a question about another gem, but I could also be off base about its use within requests.
It's being passed here:
https://github.com/ankane/searchkick/blob/f648810d5cd7f5bc018bb4ff1251831dd6784cbb/lib/searchkick.rb#L106

but never see it included in the body. Would appreciate any guidance.

Thank you!

@lizzzp1 lizzzp1 closed this as completed Apr 24, 2024
@lizzzp1 lizzzp1 reopened this Apr 24, 2024
@lizzzp1 lizzzp1 closed this as completed Apr 24, 2024
@lizzzp1
Copy link
Author

lizzzp1 commented Apr 24, 2024

I think this should actually be request level so closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant