-
Notifications
You must be signed in to change notification settings - Fork 24.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Slow log fails after upgrading from 6.8.3 to 7.4.0 #48358
Comments
This commit fixes the usage of JsonStringEncoder#quoteAsUTF8 in the SearchSlowLog. JsonStringEncoder#getInstance should always be called to get a thread local object but this assumption was broken by elastic#44642. This means that any slow log can throw an AIOOBE since it uses the same byte array concurrently. Closes elastic#48358
Pinging @elastic/es-core-infra (:Core/Infra/Logging) |
Thanks @jimczi for the very fast reaction! Do you think that we can still use slow log then (at least partially) or will it cause client visible errors? |
I don't think you should activate the slow logs in |
This commit fixes the usage of JsonStringEncoder#quoteAsUTF8 in the SearchSlowLog. JsonStringEncoder#getInstance should always be called to get a thread local object but this assumption was broken by #44642. This means that any slow log can throw an AIOOBE since it uses the same byte array concurrently. Closes #48358
This commit fixes the usage of JsonStringEncoder#quoteAsUTF8 in the SearchSlowLog. JsonStringEncoder#getInstance should always be called to get a thread local object but this assumption was broken by #44642. This means that any slow log can throw an AIOOBE since it uses the same byte array concurrently. Closes #48358
This commit fixes the usage of JsonStringEncoder#quoteAsUTF8 in the SearchSlowLog. JsonStringEncoder#getInstance should always be called to get a thread local object but this assumption was broken by #44642. This means that any slow log can throw an AIOOBE since it uses the same byte array concurrently. Closes #48358
A [bug](elastic#48358) in 7.4.0 prevents the activation of the search slow log. This change adds an entry in the release notes to warn users to not activate it in this version. Relates elastic#48358
This commit fixes the usage of JsonStringEncoder#quoteAsUTF8 in the SearchSlowLog. JsonStringEncoder#getInstance should always be called to get a thread local object but this assumption was broken by #44642. This means that any slow log can throw an AIOOBE since it uses the same byte array concurrently. Closes #48358
Elasticsearch version: Version: 7.4.0, Build: default/tar/22e1767283e61a198cb4db791ea66e3f11ab9910/2019-09-27T08:36:48.569419Z, JVM: 11.0.4
Plugins installed: [repository-s3]
JVM version: openjdk version "11.0.4" 2019-07-16
OpenJDK Runtime Environment (build 11.0.4+11-post-Debian-1bpo91)
OpenJDK 64-Bit Server VM (build 11.0.4+11-post-Debian-1bpo91, mixed mode, sharing)
OS version: Linux es-node01 4.9.0-9-amd64 #1 SMP Debian 4.9.168-1+deb9u4 (2019-07-19) x86_64 GNU/Linux
Description of the problem including expected versus actual behavior:
We're seeing the following log message in our Elasticsearch logs after upgrading from ES 6.8.3 to 7.4.0:
At least some slow logs are still being logged, so it doesn't seem entirely broken, but still we're worried about the errors.
Steps to reproduce:
Unknown unfortunately, since we cannot isolate the traffic that's causing the warnings to be logged.
Thanks for your support :-)
The text was updated successfully, but these errors were encountered: