Verify shards index UUID when fetching started shards #10200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bleskes wanna take a look |
| public ActionFuture<NodesGatewayStartedShards> list(ShardId shardId, String[] nodesIds, @Nullable TimeValue timeout) { | ||
| return execute(new Request(shardId, nodesIds).timeout(timeout)); | ||
| public ActionFuture<NodesGatewayStartedShards> list(ShardId shardId, String indexUUID, String[] nodesIds, @Nullable TimeValue timeout) { | ||
| return execute(new Request(shardId, indexUUID, Arrays.asList(nodesIds)).timeout(timeout)); |
There was a problem hiding this comment.
I think the nodes can stay as an array. The constructor just converts to an array again.
There was a problem hiding this comment.
yeah so I did this since I didn't want the String, String... signature.. kind of confusing
There was a problem hiding this comment.
agreed, but what's wrong with Request(ShardId shardId, String[] nodesIds) ?
|
Left one minor comment. LGTM otherwise. |
|
pushed a new commit |
Today we simply fetch the shards metadata without verifying the index UUID the shard belongs to. We recently added this UUID to the shard state metadata. This commit adds verification to the shard metadata fetching to prevent bringing shards back into an index it doesn't belong to due to name collisions.
|
LGTMx2 |
clintongormley
changed the title
lcawl
added
:Distributed/Distributed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today we simply fetch the shards metadata without verifying the
index UUID the shard belongs to. We recently added this UUID
to the shard state metadata. This commit adds verification
to the shard metadata fetching to prevent bringing shards
back into an index it doesn't belong to due to name collisions.