Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESQL: ENRICH attribute handling inconsistent with EVAL, GROK, ... #105807

Open
alex-spies opened this issue Feb 26, 2024 · 1 comment
Open

ESQL: ENRICH attribute handling inconsistent with EVAL, GROK, ... #105807

alex-spies opened this issue Feb 26, 2024 · 1 comment
Assignees
Labels
:Analytics/ES|QL AKA ESQL Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >tech debt

Comments

@alex-spies
Copy link
Contributor

For ENRICH with a WITH statement, the attributes it creates are handled differently from EVAL and GROK/DISSECT.

E.g. a query with... | ENRICH languages_policy ON a WITH name = language_name has an Enrich logical/physical plan, and the Expression for the language_name attribute is an Alias called name.

Weirdly, we need to handle the unaliased language_name ReferenceAttribute directly in PhysicalPlanOptimizer.ProjectAwayColumns. A similar hack is currently required to make the DependencyCheck work on LogicalPlans.

This should be refactored so that the attribute handling is analogous to EVAL and GROK/DISSECT.

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Feb 26, 2024
@alex-spies alex-spies self-assigned this Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/ES|QL AKA ESQL Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >tech debt
Projects
None yet
Development

No branches or pull requests

2 participants