Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor TransportIndicesAliasesAction action loop for ease of understanding #107017

Open
parkertimmins opened this issue Apr 2, 2024 · 1 comment
Assignees
Labels
:Data Management/Indices APIs APIs to create and manage indices and templates >enhancement Team:Data Management Meta label for data/management team

Comments

@parkertimmins
Copy link
Contributor

Description

While working on #106514 , it became clear that the main method of TransportIndicesAliasesAction has grown unwieldy. In particular, the large loop over request actions with multiple continue statements is difficult to understand.

A possible refactoring would involve moving the sections of the loop that focus on concrete indices and data streams into their own functions. Then rather than continuing from the data streams portion of the loop (here), the data stream function would call into the concrete index function.

@parkertimmins parkertimmins added >enhancement :Data Management/Indices APIs APIs to create and manage indices and templates labels Apr 2, 2024
@parkertimmins parkertimmins self-assigned this Apr 2, 2024
@elasticsearchmachine elasticsearchmachine added the Team:Data Management Meta label for data/management team label Apr 2, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Data Management/Indices APIs APIs to create and manage indices and templates >enhancement Team:Data Management Meta label for data/management team
Projects
None yet
Development

No branches or pull requests

2 participants