Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Associate text_expansion subsearch with parent search request #107077

Open
prwhelan opened this issue Apr 3, 2024 · 1 comment
Open

[ML] Associate text_expansion subsearch with parent search request #107077

prwhelan opened this issue Apr 3, 2024 · 1 comment
Labels
>enhancement :ml Machine learning Team:ML Meta label for the ML team

Comments

@prwhelan
Copy link
Member

prwhelan commented Apr 3, 2024

Description

A text_expansion subsearch is hardcoded to time out after 10s, ignoring any timeout configured in the parent search task.

For example:

GET kibana_sample_data_logs/_search
{
  "timeout": "30s",
  "query": {
    "text_expansion": {
      "message": {
        "model_id": ".elser_model_2",
        "model_text": "the query string"
      }
    }
  }
}

If the text_expansion takes longer than 10s, it will time out and throw an error, ignoring the 30s configuration.

Options:

  1. Pass the configured timeout value from the parent search to the subsearches: prwhelan@241296d
  2. Associate the subsearch task with the parent task and remove the hardcoded timeout from the test_expansion task. When the parent task is canceled, all children will be canceled.
@prwhelan prwhelan added >enhancement :ml Machine learning Team:ML Meta label for the ML team labels Apr 3, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>enhancement :ml Machine learning Team:ML Meta label for the ML team
Projects
None yet
Development

No branches or pull requests

2 participants