Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TransportService should honor handler executor on failure #107439

Open
dnhatn opened this issue Apr 12, 2024 · 1 comment
Open

TransportService should honor handler executor on failure #107439

dnhatn opened this issue Apr 12, 2024 · 1 comment
Assignees
Labels
>bug :Distributed/Network Http and internode communication implementations Team:Distributed Meta label for distributed team

Comments

@dnhatn
Copy link
Member

dnhatn commented Apr 12, 2024

There are instances where the TransportService may invoke onFailure using a thread other than the one specified in the handler executor.

at org.elasticsearch.action.ActionListenerImplementations.safeAcceptException(ActionListenerImplementations.java:62)
at org.elasticsearch.action.ActionListener$1.onFailure(ActionListener.java:140)
at org.elasticsearch.action.ActionListenerResponseHandler.handleException(ActionListenerResponseHandler.java:53)
at org.elasticsearch.transport.TransportService.handleSendRequestException(TransportService.java:859)
at org.elasticsearch.transport.TransportService.getConnectionOrFail(TransportService.java:781)
at org.elasticsearch.transport.TransportService.sendRequest(TransportService.java:757)
at org.elasticsearch.transport.TransportService.sendRequest(TransportService.java:747)

This also happens with RemoteAwareClient:

at org.elasticsearch.action.ActionListenerImplementations.safeAcceptException(ActionListenerImplementations.java:62)
at org.elasticsearch.action.ActionListenerImplementations.safeOnFailure(ActionListenerImplementations.java:73)
at org.elasticsearch.action.DelegatingActionListener.onFailure(DelegatingActionListener.java:31)
at org.elasticsearch.action.ActionListenerImplementations$ResponseWrappingActionListener.onResponse(ActionListenerImplementations.java:247)
at org.elasticsearch.transport.RemoteClusterAwareClient.maybeEnsureConnected(RemoteClusterAwareClient.java:71)
at org.elasticsearch.transport.RemoteClusterAwareClient.execute(RemoteClusterAwareClient.java:41)
@dnhatn dnhatn added >bug :Distributed/Network Http and internode communication implementations labels Apr 12, 2024
@elasticsearchmachine elasticsearchmachine added the Team:Distributed Meta label for distributed team label Apr 12, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug :Distributed/Network Http and internode communication implementations Team:Distributed Meta label for distributed team
Projects
None yet
Development

No branches or pull requests

3 participants