Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Binary fields should have doc values enabled by default for index modes using synthetic source #107554

Closed
lkts opened this issue Apr 16, 2024 · 1 comment · Fixed by #107739
Closed

Binary fields should have doc values enabled by default for index modes using synthetic source #107554

lkts opened this issue Apr 16, 2024 · 1 comment · Fixed by #107739
Labels
>enhancement :StorageEngine/Mapping The storage related side of mappings Team:StorageEngine

Comments

@lkts
Copy link
Contributor

lkts commented Apr 16, 2024

Description

Currently binary field type by default is not stored and does not have doc values. This means that in default configuration it does not support synthetic source since synthetic source requires doc values.
Similar to #106338 we should consider enabling doc values for binary by default for specific index modes like time series. Otherwise, creating an index with binary field time series mode and all default values will always fail resulting in confusing user experience.

Related to #107549.
@lkts lkts added >enhancement needs:triage Requires assignment of a team area label :StorageEngine/TSDB You know, for Metrics Team:StorageEngine :StorageEngine/Logs You know, for Logs :StorageEngine/Mapping The storage related side of mappings labels Apr 16, 2024
@elasticsearchmachine elasticsearchmachine removed the needs:triage Requires assignment of a team area label label Apr 16, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-storage-engine (Team:StorageEngine)

@martijnvg martijnvg removed :StorageEngine/TSDB You know, for Metrics :StorageEngine/Logs You know, for Logs labels Apr 22, 2024
@martijnvg martijnvg mentioned this issue Apr 22, 2024
Merged
@lkts lkts mentioned this issue Apr 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
>enhancement :StorageEngine/Mapping The storage related side of mappings Team:StorageEngine
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Binary field enables doc values by default for index mode with synthetic source lkts/elasticsearch
3 participants
@martijnvg @lkts @elasticsearchmachine