Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove GeoShapeFieldMapper #108979

Open
lkts opened this issue May 23, 2024 · 2 comments
Open

Remove GeoShapeFieldMapper #108979

lkts opened this issue May 23, 2024 · 2 comments
Labels
:Analytics/Geo Indexing, search aggregations of geo points and shapes >enhancement :StorageEngine/Mapping The storage related side of mappings Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) Team:StorageEngine

Comments

@lkts
Copy link
Contributor

lkts commented May 23, 2024

Description

GeoShapeFieldMapper is not used and superseeded by GeoShapeWithDocValuesFieldMapper.

One issue with removing it is usage in

elasticsearch/x-pack/plugin/spatial/src/main/java/org/elasticsearch/xpack/spatial/index/mapper/GeoShapeWithDocValuesFieldMapper.java

Line 107 in 4878509

private static final DeprecationLogger DEPRECATION_LOGGER = DeprecationLogger.getLogger(GeoShapeFieldMapper.class);
which is a potential breaking change.
@lkts lkts added >enhancement :Analytics/Geo Indexing, search aggregations of geo points and shapes needs:triage Requires assignment of a team area label :StorageEngine/Mapping The storage related side of mappings labels May 23, 2024
@elasticsearchmachine elasticsearchmachine added Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) Team:StorageEngine labels May 23, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@elasticsearchmachine elasticsearchmachine removed the needs:triage Requires assignment of a team area label label May 23, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-storage-engine (Team:StorageEngine)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
:Analytics/Geo Indexing, search aggregations of geo points and shapes >enhancement :StorageEngine/Mapping The storage related side of mappings Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) Team:StorageEngine
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lkts @elasticsearchmachine