Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing test coverage for spatial search for un-indexed and no-doc-values #110149

Open
craigtaverner opened this issue Jun 25, 2024 · 1 comment
Assignees
Labels
:Analytics/ES|QL AKA ESQL Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test Issues or PRs that are addressing/adding tests

Comments

@craigtaverner
Copy link
Contributor

craigtaverner commented Jun 25, 2024

Currently test coverage for spatial search for spatial types that are not indexed and/or have no doc-values is untested.

For example:

{
  "properties" : {
    "point": { "type" : "geo_point",  "index" : false, "doc_values" : false }
  }
}

An appropriate place for testing this would be a file like 130_spatial.yml, or a new one close to that like 131_spatial_dv.yml.

We should test combinations of:

  • Simply reading fields
  • Using spatial search functions with lucene push-down
  • Using spatial search functions without lucene push-down (eg. after stats or some other blocking command)
  • Using spatial aggregations (like ST_CENTROID_AGG) that trigger reading from doc-values
  • Combined with index:false, doc_values:false and both false
@craigtaverner craigtaverner added Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) :Analytics/ES|QL AKA ESQL labels Jun 25, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@craigtaverner craigtaverner self-assigned this Jun 25, 2024
@astefan astefan added the >test Issues or PRs that are addressing/adding tests label Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/ES|QL AKA ESQL Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test Issues or PRs that are addressing/adding tests
Projects
None yet
Development

No branches or pull requests

3 participants