Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mappings: Restrict unexpected characters from field names #12094

Closed
pickypg opened this issue Jul 7, 2015 · 1 comment
Closed

Mappings: Restrict unexpected characters from field names #12094

pickypg opened this issue Jul 7, 2015 · 1 comment
Labels
>breaking >enhancement :Search Foundations/Mapping Index mappings, including merging and defining field types

Comments

@pickypg
Copy link
Member

pickypg commented Jul 7, 2015

You can manage to slip unexpected characters into field names, like \n, \0 (\u0000), \t, \', \", etc. I think that we should prevent this, but the change would create a backwards incompatible restriction.

Big caveat/counter argument: as long as they're escaped, these unexpected characters are valid JSON.
@pickypg pickypg added >enhancement >breaking discuss :Search Foundations/Mapping Index mappings, including merging and defining field types labels Jul 7, 2015
@jpountz
Copy link
Contributor

jpountz commented Jul 8, 2015

Duplicate of #9059

@jpountz jpountz closed this as completed Jul 8, 2015
@kevinkluge kevinkluge removed the discuss label Jul 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
>breaking >enhancement :Search Foundations/Mapping Index mappings, including merging and defining field types
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jpountz @kevinkluge @pickypg