Add timeout mechanism for sending shard failures #14707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -578,7 +580,9 @@ void performOnPrimary(final ShardRouting primary, final ShardIterator shardsIt) | |||
| PrimaryOperationRequest por = new PrimaryOperationRequest(primary.id(), internalRequest.concreteIndex(), internalRequest.request()); | |||
| Tuple<Response, ReplicaRequest> primaryResponse = shardOperationOnPrimary(observer.observedState(), por); | |||
| logger.trace("operation completed on primary [{}]", primary); | |||
| replicationPhase = new ReplicationPhase(shardsIt, primaryResponse.v2(), primaryResponse.v1(), observer, primary, internalRequest, listener, indexShardReference); | |||
| // TODO: set a default timeout | |||
| TimeValue shardFailedTimeout = settings.getAsTime(REPLICATION_ACTION_SHARD_FAILURE_TIMEOUT, null); | |||
There was a problem hiding this comment.
in generation, this should be a variable that's resolved and cached. We shouldn't do settings lookups with each op.
There was a problem hiding this comment.
Addressed in 58fb561c45f4fd9446895adb5f82bdffb26f3cc9.
|
Left some comments. |
| ShardRoutingEntry shardRoutingEntry = new ShardRoutingEntry(shardRouting, indexUUID, message, failure); | ||
| TransportRequestOptions options = TransportRequestOptions.options(); |
There was a problem hiding this comment.
nit - why not initialize the options to EMPTY and only create a new object under the if?
There was a problem hiding this comment.
Good call. Changed in d1dd9d2d2a1e18afe4454c7adaa18098f55c9e1b.
|
LGTM |
This commit adds a timeout mechanism for sending shard failures. The requesting thread can attach a listener to the timeout event so that handling it is part of the event chain. Relates #14252
jasontedor
added a commit
that referenced
this pull request
Nov 17, 2015
Add timeout mechanism for sending shard failures
clintongormley
added
:Distributed/Distributed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a timeout mechanism for sending shard failures. The
requesting thread can attach a listener to the timeout event so that
handling it is part of the event chain.
Relates #14252