Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict index names to ASCII #15553

Closed
ywelsch opened this issue Dec 18, 2015 · 7 comments
Closed

Restrict index names to ASCII #15553

ywelsch opened this issue Dec 18, 2015 · 7 comments
Labels
>bug :Data Management/Indices APIs APIs to create and manage indices and templates discuss

Comments

@ywelsch
Copy link
Contributor

ywelsch commented Dec 18, 2015

Index names are currently used as folder names to store data. On some systems this can lead to issues when index names contain characters outside the ASCII range. We currently already forbid special characters in index names such as '', '/', '*', '?', '"', '<', '>', '|', ' ', ','.

Relates to #15552

@ywelsch ywelsch added >bug :Data Management/Indices APIs APIs to create and manage indices and templates labels Dec 18, 2015
@jpountz
Copy link
Contributor

jpountz commented Dec 19, 2015

+1

@nik9000
Copy link
Member

nik9000 commented Dec 19, 2015

Index names are currently used as folder names to store data.

I'd be just as happy to break that relationship.

@jpountz
Copy link
Contributor

jpountz commented Dec 19, 2015

Relates to #9059 as well.

@nik9000
Copy link
Member

nik9000 commented Dec 19, 2015

I'd be just as happy to break that relationship.

Actually the more I think about the more I'd prefer to break that relationship. I'd like us to be able to atomically rename an index and leave behind an alias pointing to the new index one day. And that'd require breaking the relationship between index name and directory name.

@ywelsch
Copy link
Contributor Author

ywelsch commented Dec 19, 2015

@nik9000 I'm very much in favour of breaking that relationship as well (Index UUIDs play a key role in this). I added the discussion label as we should probably come up with a plan when and how to tackle this and related issues (e.g. #13265 , #14932). I also wonder whether we should strive for a short term solution (restrict index names) and, at the same time, start thinking about more concrete plans for changing the representation on disk.

@drewr
Copy link
Contributor

drewr commented Dec 29, 2015

/me presses 👍 button

@clintongormley
Copy link

Closing in favour of #16442

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug :Data Management/Indices APIs APIs to create and manage indices and templates discuss
Projects
None yet
Development

No branches or pull requests

5 participants