Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align the regex implementation in SignificantTermsBuilder and TermsBuilder #16231

Closed
danielmitterdorfer opened this issue Jan 26, 2016 · 3 comments

Comments

@danielmitterdorfer
Copy link
Member

In TermsBuilder we switched from java.util.Regex to org.apache.lucene.util.automaton.RegExp but SignificantTermsBuilder still uses java.util.Regex. We should align both implementations and use org.apache.lucene.util.automaton.RegExp consistently.

@colings86
Copy link
Contributor

This should be done once the agg refactoring has been merged. Marking as stalled for now until that is complete

@ideadapt
Copy link

ideadapt commented Jan 2, 2018

@colings86 & @danielmitterdorfer The aggregation refactoring has changed namings and structure of code. SignificantTermsAggregationBuilder uses org.apache.lucene.util.automaton.RegExp. I could not find any Terms related class that uses java.util.Regex.
Has this issue become obsolete?

@polyfractal
Copy link
Contributor

It does indeed look like this issue is obsolete, I can't find any java.util.Regex either. Closing! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants