Add heap size bootstrap check #17728
Conversation
| try { | ||
| Object maxHeapSizeVmOption = vmOptionMethod.invoke(hotSpotDiagnosticMXBean, "MaxHeapSize"); | ||
| info.configuredMaxHeapSize = Long.parseLong((String) valueMethod.invoke(maxHeapSizeVmOption)); | ||
| } catch (Exception ignored) { |
There was a problem hiding this comment.
Do you think maybe we should WARN or something if this happens?
There was a problem hiding this comment.
@nik9000 By the time we get that far in that block, nothing should happen there and those try/catch blocks are defensive more than anything. The expected way to see an exception out of that entire block is if the end user is not on the HotSpot VM or com.sun.management.HotSpotDiagnosticMXBean is otherwise unavailable.
I do not think that we should log in that case as there is nothing the user can actively do other than switch to HotSpot. But we don't support non-HotSpot. 😄
What I do think that we should do though is write a test that tests that these methods do work on HotSpot because otherwise they can silently be broken and we will never no. I will take that on.
|
Seems fine with me. Left non-critical comments. |
This commit adds a bootstrap check to ensure that the initial heap size and max heap size are set equal to each other.
This commit adds a bootstrap check to ensure that the initial heap size
and max heap size are set equal to each other.
Closes #17490