Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List custom thread pools in _cat/thread_pool #18033

Closed
avlukanin opened this issue Apr 28, 2016 · 4 comments
Closed

List custom thread pools in _cat/thread_pool #18033

avlukanin opened this issue Apr 28, 2016 · 4 comments

Comments

@avlukanin
Copy link

Describe the feature:

It is easy to create a custom thread pool in elasticsearch.yml, e.g.:

threadpool.asdf.type: fixed
threadpool.asdf.size: 10

But this thread pool is not listed, when you use _cat/thread_pool?v=asdf command, because only SUPPORTED_NAMES can be listed in org.elasticsearch.rest.action.cat.RestThreadPoolAction#getTableWithHeader

@avlukanin avlukanin changed the title Custom thread pools are not listed in _cat/thread_pool List custom thread pools in _cat/thread_pool Apr 28, 2016
@clintongormley
Copy link

We've been talking about adding a class which is responsible for creating threads. Any other class that needs a thread pool should register its requirements with this class, and they should be available in the stats.

Related to #17915 and #12666

@avlukanin
Copy link
Author

The stats is already collected for custom thread pools, but not shown. I had to patch RestThreadPoolAction to add my custom thread pool name to SUPPORTED_NAMES and SUPPORTED_ALIASES to show it.

Can you confirm, that the stats for custom thread pools will not only be collected, but shown as well, when the new paradigm is implemented?

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

@colings86 colings86 added the :Data Management/CAT APIs Text APIs behind /_cat label Apr 24, 2018
@martijnvg
Copy link
Member

This was fixed in #19721.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants