Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate optimize_bbox on geo queries #20014

Closed
jpountz opened this issue Aug 16, 2016 · 1 comment
Closed

Deprecate optimize_bbox on geo queries #20014

jpountz opened this issue Aug 16, 2016 · 1 comment
Labels
:Analytics/Geo Indexing, search aggregations of geo points and shapes >enhancement

Comments

@jpountz
Copy link
Contributor

jpountz commented Aug 16, 2016

This puts the responsibility on the user to figure out the most efficient query plan, which is very hard as it depends on many factors such as the indexed data, the cost of computing distances vs. the bbox, the selectivity of the query, the selectivity of the other required parts of the query etc. We should remove it from the API and try to figure out query plans internally.

In terms of backward compatibility, I think we can only work on 5.x by removing it from the Java API completely and making it deprecated on the REST layer (the parser would simply ignore it).

cc @nknize

@jpountz jpountz added >enhancement :Analytics/Geo Indexing, search aggregations of geo points and shapes labels Aug 16, 2016
@jpountz
Copy link
Contributor Author

jpountz commented Aug 23, 2016

Fixed via #20032

@jpountz jpountz closed this as completed Aug 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/Geo Indexing, search aggregations of geo points and shapes >enhancement
Projects
None yet
Development

No branches or pull requests

1 participant