found unknown setting WARN messages

[ppf2]

5.0.0-rc1

Filing from a logging cleanup pt of view.

I get what we are saying here for this is being logged on 5.x against older Marvel indices.

But does this have to be logged at the WARN level? Seems like a normal migration routine that it goes through? Does the end user need to know this? If so, can we include the index name that it changed and maybe move these to the INFO level, etc.. :)

[2016-10-13T16:50:15,981][WARN ][o.e.c.s.IndexScopedSettings] [p9eEwZW] found unknown setting: index.marvel.index_format value: 6 - archiving
[2016-10-13T16:50:15,981][WARN ][o.e.c.s.IndexScopedSettings] [p9eEwZW] found unknown setting: index.marvel.plugin.version value: 2.4.0 - archiving
[2016-10-13T16:50:15,981][WARN ][o.e.c.s.IndexScopedSettings] [p9eEwZW] found unknown setting: index.marvel.template.version value: 1 - archiving
[2016-10-13T16:50:16,367][WARN ][o.e.c.s.IndexScopedSettings] [p9eEwZW] found unknown setting: index.marvel.index_format value: 6 - archiving
[2016-10-13T16:50:16,367][WARN ][o.e.c.s.IndexScopedSettings] [p9eEwZW] found unknown setting: index.marvel.plugin.version value: 2.4.0 - archiving
[2016-10-13T16:50:16,368][WARN ][o.e.c.s.IndexScopedSettings] [p9eEwZW] found unknown setting: index.marvel.template.version value: 1 - archiving
[2016-10-13T16:50:16,476][WARN ][o.e.c.s.IndexScopedSettings] [p9eEwZW] found unknown setting: index.marvel.index_format value: 6 - archiving
[2016-10-13T16:50:16,714][WARN ][o.e.c.s.IndexScopedSettings] [p9eEwZW] found unknown setting: index.marvel.index_format value: 6 - archiving

[jasontedor]

But does this have to be logged at the WARN level? Seems like a normal migration routine that it goes through. Does the end user need to know this?

Yes, warn is the right level! We are ignoring settings a user thinks they have set, we absolutely should warn them.

[ppf2]

Sounds good, can we add the index name reference though ? :) So end users will not have to query the index settings api to figure out where these settings are originally set.

[jasontedor]

Yes, of course. I was only commenting on the warn request. If I disagreed with both requests I would have closed the issue. 😇

[ppf2]

Cool, thx again!

[jasontedor]

I have a fix for this. I'll open a PR soon.

[ppf2]

And thanks for this too! @jasontedor