Make sure HEAD / has 0 Content-Length #21077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit `curl -XHEAD localhost:9200?pretty` would return `Content-Length: 1` and a body which is fairly upsetting to standards compliant tools. Now it'll return `Content-Length: 0` with an empty body like every other `HEAD` request. Relates to elastic#21075
nik9000
added
>bug
review
:Core/Infra/REST API
jasontedor
approved these changes
Oct 21, 2016
|
Thanks for reviewing @jasontedor ! Merged to: |
nik9000
added a commit
that referenced
this pull request
Oct 21, 2016
Before this commit `curl -XHEAD localhost:9200?pretty` would return `Content-Length: 1` and a body which is fairly upsetting to standards compliant tools. Now it'll return `Content-Length: 0` with an empty body like every other `HEAD` request. Relates to #21075
nik9000
added a commit
that referenced
this pull request
Oct 21, 2016
Before this commit `curl -XHEAD localhost:9200?pretty` would return `Content-Length: 1` and a body which is fairly upsetting to standards compliant tools. Now it'll return `Content-Length: 0` with an empty body like every other `HEAD` request. Relates to #21075
|
Thank you so much @jasontedor and @nik9000, amazing turn around time! |
This was partially addressed in #21123, at least the correct content-length can be passed through now. We still have some handlers that handle head requests on their own and that needs to be removed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit
curl -XHEAD localhost:9200?prettywould returnContent-Length: 1and a body which is fairly upsetting to standardscompliant tools. Now it'll return
Content-Length: 0with an emptybody like every other
HEADrequest.Relates to #21075