Should we allow Painless scripts to be longer?

[nik9000]

Right now we hard code the limit on Painless scripts. I think the limit we set was fairly arbitrary. I've had folks ask about bumping the limit. Maybe we should bump the limit ourselves or make it a part of the script script context when we have a context?

[rjernst]

I think it should be part of the context.

[clintongormley]

The context is hard coded, no? In that case, which contexts would have an increased size limit?

[clintongormley]

Discussed in FixItFriday - contexts may make sense, eg search scripts should be small and fast, while update scripts might allow for more complexity.

[uschindler]

This is no rwal limitation, it's only for display purposes. You misunderstood that! Scripts can be longer, of course. It is just that the stack trace would not contain the full painless script as source code where normal classes have the file name. This is just a limitation of the class file format, not arbitrary.

[uschindler]

Oh sorry, ignore that. It's not the limit in the class file generator.

[conquel]

@cbuescher #25527 I have nearly 150 variables which must be passed to the script which handles calculations between these variables and the same number of fields in a document, then documents are scored by the resulting value.
I don't think it is possible to efficiently encourage making faster scripts by limiting their maximum length. One can have long variable names which exhaust the allowed size, but virtually no math. Or you can have a 100 bytes script with a heavy loop. So, I propose to leave performance considerations to the developer.
Thus, @nik9000, it's a great idea to have this limit lifted in the next release, please do so. Otherwise we would have to make a custom build just to change that number.

[morphers82]

Any possibility of allowing larger painless scripts in 6.0?

[nerophon]

Another user has requested that this hardcoded limit be increased or removed. It is preventing them fulfilling their requirements.

[jdconrad]

Contexts are done so probably worth adding this as a setting at some point.

[jasontedor]

Closed by #35184

[ypid-geberit]

Thanks for fixing!

I found another issue with the size limit which is that source code comments also count to the total script length. Because my scripts are usually well commented, I now hit this limit so I needed to implement a way to minify Painless scripts before sending them to ES as workaround. Refer to --minify-scripts elastic/examples#239