Initialize checkpoint tracker with allocation ID #26630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit pushes the allocation ID down through to the global checkpoint tracker at construction rather than when activated as a primary.
ywelsch
approved these changes
Sep 13, 2017
| @@ -198,6 +200,7 @@ | |||
| public class InternalEngineTests extends ESTestCase { | |||
|
|
|||
| protected final ShardId shardId = new ShardId(new Index("index", "_na_"), 0); | |||
| protected final AllocationId allocationId = AllocationId.newInitializing(); | |||
There was a problem hiding this comment.
maybe just store the string here, i.e.
protected final String allocationId = AllocationId.newInitializing().getId();
There was a problem hiding this comment.
The actual allocation ID instance is needed in one place. 😐
| @@ -117,6 +108,11 @@ public void testGlobalCheckpointUpdate() { | |||
| // it is however nice not to assume this on this level and check we do the right thing. | |||
| final long minLocalCheckpoint = allocations.values().stream().min(Long::compare).orElse(UNASSIGNED_SEQ_NO); | |||
|
|
|||
| final GlobalCheckpointTracker tracker = new GlobalCheckpointTracker( | |||
There was a problem hiding this comment.
maybe add a helper method newTracker(String allocationId), so that there is less code repetition.
jasontedor
added a commit
that referenced
this pull request
Sep 13, 2017
This commit pushes the allocation ID down through to the global checkpoint tracker at construction rather than when activated as a primary. Relates #26630
jasontedor
added a commit
that referenced
this pull request
Sep 13, 2017
This commit pushes the allocation ID down through to the global checkpoint tracker at construction rather than when activated as a primary. Relates #26630
|
Thanks @ywelsch. |
clintongormley
added
:Distributed/Engine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit pushes the allocation ID down through to the global checkpoint tracker at construction rather than when activated as a primary.
Relates #26591