Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQL: correctness of SYS TABLES/COLUMNS results #29862

Closed
elasticmachine opened this issue Jan 26, 2018 · 6 comments
Closed

SQL: correctness of SYS TABLES/COLUMNS results #29862

elasticmachine opened this issue Jan 26, 2018 · 6 comments

Comments

@elasticmachine
Copy link
Collaborator

Original comment by @costin:

The two major meta calls in JDBC and ODBC for discovery are get tables and get columns.
The latter in particular tends to be important as it describes a column type and properties through 18 fields in LINK REDACTED) and 24 in LINK REDACTED.

While JDBC ignores most of them, ODBC does not. This issue is about checking that the values returns properly describe the types and obey the ODBC spec - for example fields like SQL_DATETIME_SUB are not returned properly.
This ties also into type info (LINK REDACTED and LINK REDACTED).

P.S. This issue is not urgent - rather acts as a reminder.

@elasticmachine
Copy link
Collaborator Author

Original comment by @bpintea:

The return value in UNSIGNED_ATTRIBUTE column should be set to false for numeric values, since they are actually signed in ES.

@elasticmachine
Copy link
Collaborator Author

Original comment by @bpintea:

'SYS COLUMNS' should not return null in BUFFER_LENGTH column.

@elasticmachine
Copy link
Collaborator Author

Original comment by @costin:

@bpintea okay but what should be the value for BUFFER_LENGTH then?

@elasticmachine
Copy link
Collaborator Author

Original comment by @costin:

@bpintea There's no column UNSIGNED_ATTRIBUTE defined in either columns or tables. I've looked at the ODBC spec for columns LINK REDACTED and couldn't find it there either.

@elasticmachine
Copy link
Collaborator Author

Original comment by @bpintea:

Just to note, the UNSIGNED_ATTRIBUTE comment was assigned incorrectly to this ticket, it concerns the correctness of SYS TYPES resultset.

@costin
Copy link
Member

costin commented May 17, 2018

Addressed by #30530, #30418, #30516 (and several others in the old repo)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants