Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQL: Move away from JDBCType to SQLType #33904

Closed
costin opened this issue Sep 20, 2018 · 2 comments · Fixed by #33913
Closed

SQL: Move away from JDBCType to SQLType #33904

costin opened this issue Sep 20, 2018 · 2 comments · Fixed by #33913
Labels
:Analytics/SQL SQL querying >enhancement v6.5.0 v7.0.0-beta1

Comments

@costin
Copy link
Member

costin commented Sep 20, 2018

Internally and inside the JDBC driver, JDBCType is being used for the standard SQL representation. Unfortunately this is too restrictive as it doesn't cover even the standard SQL types (such as INTERVAL).
Fortunately, Java 8 introduced SQLType an interface for extensibility which we should be using instead.
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search-aggs

@costin costin mentioned this issue Sep 24, 2018
Merged
@costin
Copy link
Member Author

costin commented Sep 24, 2018

Closed by #33913

@costin costin closed this as completed Sep 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
:Analytics/SQL SQL querying >enhancement v6.5.0 v7.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

SQL: Move away internally from JDBCType to SQLType costin/elasticsearch
3 participants
@costin @colings86 @elasticmachine