[Monitoring] Updating test assertion #34040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/es-core-infra |
pickypg
approved these changes
Oct 1, 2018
tlrx
approved these changes
Oct 2, 2018
ycombinator
deleted the
follow-up/x-pack/monitoring/collect-cluster-metadata
branch
ycombinator
added a commit
to ycombinator/elasticsearch
that referenced
this pull request
Oct 2, 2018
kcm
pushed a commit
that referenced
this pull request
Oct 30, 2018
ycombinator
added a commit
that referenced
this pull request
Nov 5, 2018
) Backport of #33860 and #34040. This PR teaches Monitoring to collect cluster metadata, if any is set, and index it into `cluster_stats` docs in `.monitoring-es-*`. After this PR, `cluster_stats` docs in `.monitoring-es-*` will contain an additional top-level `cluster_settings` field like so: ``` { ... "cluster_settings": { "cluster": { "metadata": { ... } } } } ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #33860.
This test assertion was failing when I tried to backport #33860 in #34023. So I'm fixing it in
masterand will backport it as part of #34023.