Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add grok patterns to support hostnames with underscores #35081

Open
jsoriano opened this issue Oct 30, 2018 · 1 comment
Open

Add grok patterns to support hostnames with underscores #35081

jsoriano opened this issue Oct 30, 2018 · 1 comment
Labels
:Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP >enhancement Team:Data Management Meta label for data/management team

Comments

@jsoriano
Copy link
Member

Current HOSTNAME grok pattern doesn't support hostnames with underscores.

As discussed in a PR to add this to the logstash plugin, the RFC doesn't accept underscores, but they are actually possible at least on Linux (see elastic/beats#8814), and when they are part of DNS records or in host:port patterns.

I think that HOSTNAME should accept underscores, or new patterns should be added to handle the cases where underscores could be present.
@jsoriano jsoriano added >enhancement :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP labels Oct 30, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

@jsoriano jsoriano mentioned this issue Jul 31, 2019
Closed
@sayden sayden mentioned this issue Jul 31, 2019
Closed
@rjernst rjernst added the Team:Data Management Meta label for data/management team label May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
:Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP >enhancement Team:Data Management Meta label for data/management team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Filebeat] HOSTNAME Grok pattern doesn't accept underscores sayden/beats
3 participants
@jsoriano @rjernst @elasticmachine