Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Monitoring] Make LocalExporter::openBulk Async #35797

Closed
pickypg opened this issue Nov 21, 2018 · 4 comments · Fixed by #36606
Closed

[Monitoring] Make LocalExporter::openBulk Async #35797

pickypg opened this issue Nov 21, 2018 · 4 comments · Fixed by #36606
Assignees
@pickypg
Labels
:Data Management/Monitoring >enhancement

Comments

@pickypg
Copy link
Member

pickypg commented Nov 21, 2018

This is a spin-off from #35765 and #35743, but specifically targeting the LocalExporter bulk initialization code.

Like #35765 is doing with the HttpExporter::openBulk, the LocalExporter::openBulk initialization code needs to be made truly, fully async as well.
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features

@pickypg pickypg mentioned this issue Nov 21, 2018
Merged
@ekalgolas
Copy link
Contributor

Can I work on this?

@pickypg
Copy link
Member Author

pickypg commented Nov 22, 2018

@ekalgolas I was going to start work on this issue early next week, and it depends on the work done in #35765, which is not yet merged. It's probably best to find another issue.

@ekalgolas
Copy link
Contributor

ohk sure no worries

@pickypg pickypg self-assigned this Nov 22, 2018
@pickypg pickypg mentioned this issue Dec 13, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pickypg pickypg

Labels
:Data Management/Monitoring >enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Monitoring] LocalExporter should catch synchronous exceptions pickypg/elasticsearch
3 participants
@pickypg @ekalgolas @elasticmachine