Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inner hits fail to propagate doc-value format. #36310

Merged
merged 1 commit into from Dec 7, 2018
Merged

Inner hits fail to propagate doc-value format. #36310

merged 1 commit into from Dec 7, 2018

Conversation

jpountz
Copy link
Contributor

@jpountz jpountz commented Dec 6, 2018

If you pass a doc-value format to inner hits, it gets ignored.

@jpountz
Inner hits fail to propagate doc-value format.
d5f8ae3 
If you pass a doc-value format to inner hits, it gets ignored.
@jpountz jpountz added >bug :Search/Search Search-related issues that do not fall into other categories labels Dec 6, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search

javanna
javanna approved these changes Dec 6, 2018
View reviewed changes
Copy link
Member

@javanna javanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@javanna
Copy link
Member

javanna commented Dec 6, 2018

heya @jpountz what issues would this cause practically?

@jpountz
Copy link
Contributor Author

jpountz commented Dec 6, 2018

@javanna There are two practical issues:

  • First it prevents you from passing custom formats, such as epoch_millis for dates.
  • Second we are changing the default for doc-value fields to use mappings to format fields via the special use_field_mapping in 6.x which becomes the default behavior in 7.x. This bug means that 6.x users can't opt in for the 7.x behavior at the moment.

@jpountz jpountz merged commit 266b9bc into elastic:master Dec 7, 2018
@jpountz jpountz deleted the fix/dv_format_inner_hits branch December 7, 2018 09:00
jpountz added a commit to jpountz/elasticsearch that referenced this pull request Dec 7, 2018
@jpountz
Inner hits fail to propagate doc-value format. (elastic#36310)
9c97781 
If you pass a doc-value format to inner hits, it gets ignored.
@jpountz jpountz mentioned this pull request Dec 7, 2018
Merged
@jpountz jpountz added the v7.0.0 label Dec 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javanna javanna javanna approved these changes

Assignees
No one assigned
Labels
>bug :Search/Search Search-related issues that do not fall into other categories v7.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jpountz @elasticmachine @javanna @colings86