Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEST] Ignore zen2 discovery task in waitForPendingTasks #36381

Merged
merged 2 commits into from Dec 10, 2018

Conversation

droberts195
Copy link
Contributor

Fixes #36380

@droberts195 droberts195 added >test Issues or PRs that are addressing/adding tests v7.0.0 :ml Machine learning labels Dec 7, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core

@davidkyle
Copy link
Member

Could the same error occur in the tests that extend MlNativeAutodetectIntegTestCase

@droberts195
Copy link
Contributor Author

Could the same error occur in the tests that extend MlNativeAutodetectIntegTestCase

Maybe, although that's a much bigger change to fix, so I'd rather do it as a separate PR if it's required. The change in this PR fixes a problem that has caused a few CI builds to fail so it would be good to get it merged ASAP.

It's not completely clear if the discovery task is supposed to run for 10+ minutes. If it is then it brings into question the functionality of the list tasks request's wait_for_completion option.

@ywelsch
Copy link
Contributor

ywelsch commented Dec 10, 2018

It's not completely clear if the discovery task is supposed to run for 10+ minutes. If it is then it brings into question the functionality of the list tasks request's wait_for_completion option.

We're working on a fix so that the discovery task completes as soon as a cluster is formed. As this fix will require some non-trivial changes, it might not be merged today. So it would be good to proceed with this quick-fix, which can then be reverted once we have the proper fix.

@droberts195 droberts195 merged commit 558f4ec into elastic:master Dec 10, 2018
@droberts195 droberts195 deleted the ignore_zen2_task branch December 10, 2018 11:07
DaveCTurner added a commit to DaveCTurner/elasticsearch that referenced this pull request Dec 10, 2018
Today the `GetDiscoveredNodesAction` waits, possibly indefinitely, to discover
enough nodes to bootstrap the cluster. However it is possible that the cluster
forms before a node has discovered the expected collection of nodes, in which
case the action will wait indefinitely despite the fact that it is no longer
required.

This commit changes the behaviour so that the action fails once a node receives
a cluster state with a nonempty configuration, indicating that the cluster has
been successfully bootstrapped and therefore the `GetDiscoveredNodesAction`
need wait no longer.

Relates elastic#36380 and elastic#36381; reverts 558f4ec.
DaveCTurner added a commit that referenced this pull request Dec 10, 2018
Today the `GetDiscoveredNodesAction` waits, possibly indefinitely, to discover
enough nodes to bootstrap the cluster. However it is possible that the cluster
forms before a node has discovered the expected collection of nodes, in which
case the action will wait indefinitely despite the fact that it is no longer
required.

This commit changes the behaviour so that the action fails once a node receives
a cluster state with a nonempty configuration, indicating that the cluster has
been successfully bootstrapped and therefore the `GetDiscoveredNodesAction`
need wait no longer.

Relates #36380 and #36381; reverts 558f4ec.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:ml Machine learning >test Issues or PRs that are addressing/adding tests v7.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants