Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQL: add tests to check the protocol stays true to its definition #36882

Closed
astefan opened this issue Dec 20, 2018 · 4 comments · Fixed by #37516
Closed

SQL: add tests to check the protocol stays true to its definition #36882

astefan opened this issue Dec 20, 2018 · 4 comments · Fixed by #37516
Labels
:Analytics/SQL SQL querying >enhancement v6.7.0 v7.0.0-beta1

Comments

@astefan
Copy link
Contributor

astefan commented Dec 20, 2018

Issues like this one were the result of enforcing the mode parameter on the ODBC driver and discovering that the driver was expecting dates in the ISO 8601 format, but SQL was making a choice in case of JDBC/ODBC to format the date as millis-since-epoch.

The protocol SQL uses in relation to its clients needs tests that make sure the protocol rules don't change unexpectedly.
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search

@costin
Copy link
Member

costin commented Dec 20, 2018

Related to this are also:
#36535
#36635
#36432

@costin
Copy link
Member

costin commented Dec 20, 2018

Potentially also #36186

@astefan astefan mentioned this issue Jan 16, 2019
Merged
@astefan
Copy link
Contributor Author

astefan commented Jan 16, 2019

master (7.0.0): 659326f
6.x (6.7.0): ac284e8

@astefan astefan mentioned this issue Jan 23, 2019
Closed
@jimczi jimczi added v7.0.0-beta1 and removed v7.0.0 labels Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
:Analytics/SQL SQL querying >enhancement v6.7.0 v7.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

SQL: Add protocol tests and remove jdbc_type from drivers response astefan/elasticsearch
4 participants
@costin @astefan @elasticmachine @jimczi