Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project fails to build in IntelliJ IDEA 2019.1 #40550

Closed
mark-vieira opened this issue Mar 27, 2019 · 2 comments
Closed

Project fails to build in IntelliJ IDEA 2019.1 #40550

mark-vieira opened this issue Mar 27, 2019 · 2 comments
Labels
:Delivery/Build Build or test infrastructure Team:Delivery Meta label for Delivery team

Comments

@mark-vieira
Copy link
Contributor

The latest version of IntelliJ, 2019.1 enforces some new constraints around module content roots. It turns out that IntelliJ does not support multiple modules with the same sources context root. That is, two modules cannot share a single source directory. Gradle does in fact support such a scenario and models it correctly and we do this in a number of places in our build. While this seemed to work with IntelliJ 2018.3 I suspect it only coincidentally worked in scenarios where one root was production source and the other was test source due to implementation details in the IntelliJ project model. This is now outright disallowed and IntelliJ will remove the duplicate root definitions at import time.

2019-03-27 10:33:26,183 [ 914974]   WARN - .manage.ContentRootDataService - Path [/Users/mark/workspaces/elasticsearch/x-pack/license-tools/src/main/java] of module [elasticsearch.x-pack.license-tools.main] was removed from modules [elasticsearch.x-pack.plugin.core.test] 

There are a number of beneficial features in IntelliJ 2019.1 so we should try and sort this out. Likely by relying on project dependencies rather than shared source directories where possible, and potentially some refactoring where not.

@mark-vieira mark-vieira added the :Delivery/Build Build or test infrastructure label Mar 27, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

@alpar-t
Copy link
Contributor

alpar-t commented Apr 11, 2019

Closed by #40877

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Delivery/Build Build or test infrastructure Team:Delivery Meta label for Delivery team
Projects
None yet
Development

No branches or pull requests

3 participants