Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

javadoc rendering in 6.7 is breaking links of same package different module #41212

Closed
hub-cap opened this issue Apr 15, 2019 · 5 comments
Closed
Labels
>bug :Delivery/Build Build or test infrastructure Team:Delivery Meta label for Delivery team

Comments

@hub-cap
Copy link
Contributor

hub-cap commented Apr 15, 2019

the HLRC depends on some code in another module that is in the same package as the client, o.e.client. In the deployed javadoc for 6.6, the links between the HLRC javadoc and this other module work fine, but in 6.7 the are broken. This is broken in 6.7 and up to master.

In the following examples, navigate to the RestClientBuilder and click or hover over it. It does not resolve to a URL with client/ in it at all.

Example working

Example broken

@hub-cap hub-cap added the >bug label Apr 15, 2019
@jasontedor
Copy link
Member

I suspect this is due to the change to use the JDK 12 compiler. It could be that this is expected behavior now (or that we were relying on a buggy behavior before), something that we would need to investigate.

@rjernst
Copy link
Member

rjernst commented Apr 15, 2019

I think the issue is we have split packages. We need to clean this up, since java modules will not support this. Building the javadocs has to guess and (arbitrarily) chooses which jar contains a given package.

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

@rjernst rjernst added the Team:Core/Infra Meta label for core/infra team label May 4, 2020
@mark-vieira mark-vieira added Team:Delivery Meta label for Delivery team and removed Team:Core/Infra Meta label for core/infra team labels Nov 11, 2020
@mark-vieira
Copy link
Contributor

Given we've "removed" the HLRC in current branches in favor of https://github.com/elastic/elasticsearch-java I think we can close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug :Delivery/Build Build or test infrastructure Team:Delivery Meta label for Delivery team
Projects
None yet
Development

No branches or pull requests

6 participants