Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] New test fails on CI #44132

Closed
przemekwitek opened this issue Jul 9, 2019 · 3 comments
Closed

[ML] New test fails on CI #44132

przemekwitek opened this issue Jul 9, 2019 · 3 comments
Assignees
Labels
>bug :ml Machine learning >test-failure Triaged test failures from CI v8.0.0-alpha1

Comments

@przemekwitek
Copy link
Contributor

Recently introduced test ("Test get stats for started datafeed contains timing stats" introduced in #43045 fails on CI with broken assertion:

java.lang.AssertionError: Failure at [ml/get_datafeed_stats:198]: datafeeds.0.timing_stats.search_count didn't match expected value:
datafeeds.0.timing_stats.search_count: expected [1] but was [0]

CI details: https://groups.google.com/a/elastic.co/forum/?utm_medium=email&utm_source=footer#!msg/build-elasticsearch/tSXaX9zxqug/jWepkleFAgAJ

@przemekwitek przemekwitek added >bug :ml Machine learning v8.0.0 labels Jul 9, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core

@przemekwitek przemekwitek self-assigned this Jul 9, 2019
@przemekwitek
Copy link
Contributor Author

One hypothesis is that the test fails because it stops the datafeed soon after starting it and the datafeed may not be able to perform search.

I'll relax the assertion for now to make the test pass and then fix the test itself.

@przemekwitek
Copy link
Contributor Author

The fix is now merged in.
Moreover, we agreed to keep this yml test only verify timing_stats existence, not the actual values. The actual values are verified in java tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug :ml Machine learning >test-failure Triaged test failures from CI v8.0.0-alpha1
Projects
None yet
Development

No branches or pull requests

4 participants