Make multi search tasks cancellable #44494
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today multi search tasks, created through MultiSearchRequest#createTask end up being the default task instance which is not cancellable. With this change we make them a search task, which is cancellable, and also cancels all the sub-tasks when cancelled.
javanna
added
>enhancement
:Search/Search
|
Pinging @elastic/es-search |
imotov
reviewed
Jul 17, 2019
|
Turns out that an integration test is needed, and it proves that cancelling msearch requests does not really cancel all the corresponding searches as there are three levels of tasks: msearch -> search -> shard level search . I will work on making cancelling a task work for this scenario, but it will require a separate change. |
|
This PR can be resumed once #50990 is fixed. |
|
I removed the stalled label, I will pick this back up shortly given that the tasks framework now supports hierarchical cancellation of tasks. |
|
This was implemented in #61337 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today multi search tasks, created through MultiSearchRequest#createTask
end up being the default task instance which is not cancellable. With
this change we make them a search task, which is cancellable, and also
cancels all the sub-tasks when cancelled.