Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't overwrite existing fields in GeoIP processor #45752

Open
jderose9 opened this issue Aug 20, 2019 · 2 comments
Open

Don't overwrite existing fields in GeoIP processor #45752

jderose9 opened this issue Aug 20, 2019 · 2 comments
Labels
:Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP >feature Team:Data Management Meta label for data/management team

Comments

@jderose9
Copy link

Please allow GeoIP processor to run without blowing away existing property values. This would be consistent with the logstash plugin which merges the objects. Perhaps a config setting to toggle overwrite/merge would be best.

I am trying to store all values in the appropriate ECS fields (for example, client.geo), and would like the client application to persist any of the geo data that it may have since it is likely more accurate.

@jimczi jimczi added :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP >feature labels Aug 21, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features

@martijnvg
Copy link
Member

Thanks for opening this issue @jderose9.

Perhaps a config setting to toggle overwrite/merge would be best.

Yes, I think so too. We properly need to default to overwrite in order to need break bwc and we can consider to default to merge in the next major version (8.0 and later). Perhaps merge_on_overwrite is a good name, as the some processors support overwrite setting that controls whether a field should overwritten if it already exists.

@rjernst rjernst added the Team:Data Management Meta label for data/management team label May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP >feature Team:Data Management Meta label for data/management team
Projects
None yet
Development

No branches or pull requests

5 participants