Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace private index settings with index metadata #50758

Closed
rjernst opened this issue Jan 8, 2020 · 6 comments
Closed

Replace private index settings with index metadata #50758

rjernst opened this issue Jan 8, 2020 · 6 comments
Labels
:Core/Infra/Settings Settings infrastructure and APIs >refactoring Team:Core/Infra Meta label for core/infra team team-discuss

Comments

@rjernst
Copy link
Member

rjernst commented Jan 8, 2020

Currently we have several "private" index settings. These are index settings which can only be set internally by Elasticsearch, not by the user. One problem with these settings is how/when/if they are copied upon copying an index (eg #44440, although there are other solutions that particular problem).

Last year we discussed using dedicated index metadata for these values, as they are not really settings, but metadata about the index tracked by the system. Such a replacement would need to make typed metadata easier, which is one reason the settings infrastructure is currently used for such values. This issue is a placeholder for discussion/design of such a replacement effort.

@rjernst rjernst added :Core/Infra/Settings Settings infrastructure and APIs >refactoring labels Jan 8, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (:Core/Infra/Settings)

@jloleysens
Copy link
Contributor

Hi @rjernst , we are currently looking at improvements for Kibana's Upgrade Assistant for 8.0. This change would in particular help us address elastic/kibana#40564.

I would like to understand the implications for Upgrade Assistant a bit better; will any special action be required when handling older indices for re-indexing?

@rjernst
Copy link
Member Author

rjernst commented Feb 25, 2020

@jloleysens This issue describes a path we would like to take with settings for greater simplification to users, but there is not yet a concrete plan for when this would happen. To answer your question, though, when this work is completed these will no longer be settings. No external action would be necessary.

@rjernst rjernst added the Team:Core/Infra Meta label for core/infra team label May 4, 2020
@jaymode
Copy link
Member

jaymode commented Jun 15, 2020

I looked into this in the context of system indices. Custom index metadata was modified to be more acceptable in #32749 and then used by CCR in #33546. This means that code running within elasticsearch has a method to put a Map of metadata within the IndexMetadata in the cluster state.

In terms of what is missing, it looks like it is the typing of the metadata. I do wonder if this is an issue though since the metadata is serialized by a plugin or other caller and not updateable via an API as far as I can see.

@rjernst rjernst added the needs:triage Requires assignment of a team area label label Dec 3, 2020
@gwbrown
Copy link
Contributor

gwbrown commented Dec 19, 2020

I'm labeling this team-discuss to determine whether we're likely to make an effort to do this in the near future or if there's another approach we should take here. #44440 is related.

@gwbrown gwbrown added team-discuss and removed needs:triage Requires assignment of a team area label labels Dec 19, 2020
@gwbrown
Copy link
Contributor

gwbrown commented Feb 10, 2021

We discussed this in the core/infra sync today and decided that while we like this proposal from an aesthetic perspective, it would be a good bit of effort and there are areas where we can spend that development effort more effectively in the near future.

Therefore, we're going close this issue and #44440 and promote the idea in #44440 (comment) to its own issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Core/Infra/Settings Settings infrastructure and APIs >refactoring Team:Core/Infra Meta label for core/infra team team-discuss
Projects
None yet
Development

No branches or pull requests

5 participants