Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create GET _cat/transforms API #51412

Closed
benwtrent opened this issue Jan 24, 2020 · 7 comments · Fixed by #53643
Closed

Create GET _cat/transforms API #51412

benwtrent opened this issue Jan 24, 2020 · 7 comments · Fixed by #53643
Labels

Comments

@benwtrent
Copy link
Member

See #51364 for more info on how to do this (but obviously put this API in the transforms plugin).

This API should return basic statistics and settings that effect those statistics.

I think the GetTransformStatsAction is a good place to start.

@benwtrent benwtrent added the :ml/Transform Transform label Jan 24, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core (:ml/Transform)

@hendrikmuhs hendrikmuhs added the help wanted adoptme label Feb 10, 2020
@zacharymorn
Copy link
Contributor

hi @benwtrent, I'm interested in this task. To clarify, is the ask to enable an API endpoint to use the existing GetTransformStatsAction to return already available stats result (used in Gateway context maybe?), or there might be more stats that need to be added into the action for this API?

@benwtrent
Copy link
Member Author

benwtrent commented Feb 28, 2020

@zacharymorn the stats call does return a ton of info. But, I think more information about the transform itself should be added.

But some additional information from the GetTransformAction:

  • source indices
  • destination indices
  • description
  • version
  • creation time
  • frequency
  • and maybe something indicating if it is continually looking at data or is/was batch (continuous is indicated if it has a sync config).

Here is an example of a similar change: #52260

If you wish to take the issue, feel free. Let me know when you start working on it and I can assign the issue to you.

@zacharymorn
Copy link
Contributor

@benwtrent Thanks for the additional information. The needed changes are clear and I'll start to work on it.

I've also gone through the internal process to get the approval to contribute on behalf of the company I'm working for (Amazon). I'll work with the relevant internal team to see how we can best contribute. Please let me know if you have any suggestion as well as this is the first time I'm contributing on behalf of a company.

Thanks,
Zach

@sophiec20
Copy link
Contributor

@zacharymorn We'd like to try to get this enhancement in for our next minor and there is a small window in which to do this. Thanks for your interest but we've found internal resource and we aim to be working on this shortly.

@zacharymorn
Copy link
Contributor

@sophiec20 Thanks for letting me know. I've actually worked on this over the weekend and should be able to open a PR tonight, please let me know if that will work for you.

@zacharymorn
Copy link
Contributor

@sophiec20 I've gone ahead and opened the PR. Please let me know if it looks good to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants