Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQL: Types class refactoring #51482

Open
astefan opened this issue Jan 27, 2020 · 4 comments
Open

SQL: Types class refactoring #51482

astefan opened this issue Jan 27, 2020 · 4 comments
Labels
:Analytics/SQL SQL querying Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo)

Comments

@astefan
Copy link
Contributor

astefan commented Jan 27, 2020

At the moment org.elasticsearch.xpack.sql.type.Types has code exclusively used in tests for testing JSON mappings' validity. The way a json containing an index mapping is loaded and interpreted, though, differs from the main code of ES SQL (residing in IndexResolver) and the algorithms are significantly different.
This means that, whenever the code in IndexResolver changes (for example - #51251), the code in Types needs to change as well which introduces an unnecessary maintenance task.

@astefan astefan added the :Analytics/SQL SQL querying label Jan 27, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (:Search/SQL)

@rjernst rjernst added the Team:QL (Deprecated) Meta label for query languages team label May 4, 2020
@soarescaique
Copy link

Can I work on this?

@matriv
Copy link
Contributor

matriv commented Dec 3, 2020

Hi @soarescaique Thank you for your interest in contributing!
Inline with common open source practices, we would like to no longer block and attribute issues, but rather invite anyone with a concrete proposal to simply submit a PR. No one likes duplicating work, but please consider that chances of concurrent PRs are low - especially for longer standing issues - and quality will trump over submission order.

@wchaparro wchaparro removed the Team:QL (Deprecated) Meta label for query languages team label Jan 17, 2024
@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Jan 17, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/SQL SQL querying Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo)
Projects
None yet
Development

No branches or pull requests

7 participants