Create new `geo` module and migrate geo_shape registration #53562

talevy · 2020-03-13T20:23:35Z

This commit introduces a new geo module that is intended
to contain all the geo-spatial-specific features in server.

As a first step, the responsibility of registering the geo_shape
field mapper is moved to this module.

This commit introduces a new spatial-extras module that is intended to be contain all the geo-spatial-specific features in server. As a first step, the responsibility of registering the geo_shape field mapper is moved to this module.

elasticmachine · 2020-03-13T20:23:37Z

Pinging @elastic/es-analytics-geo (:Analytics/Geo)

talevy · 2020-03-13T22:27:19Z

.../mapper-extras/src/test/java/org/elasticsearch/index/query/RankFeatureQueryBuilderTests.java

@@ -52,7 +52,7 @@ protected void initializeAdditionalMappings(MapperService mapperService) throws

    @Override
    protected Collection<Class<? extends Plugin>> getPlugins() {
-        return Collections.singleton(MapperExtrasPlugin.class);
+        return List.of(MapperExtrasPlugin.class, TestGeoShapeFieldMapperPlugin.class);


I think there is room to pull the TestGeoShapeFieldMapperPlugin to the parent test class and inherited by those that need it or need to extend to include more plugins. I could see it stay either way since it is fairly low impact and the dependency is expected to go away

rjernst

I have a couple questions/suggestions

.../mapper-extras/src/test/java/org/elasticsearch/index/query/RankFeatureQueryBuilderTests.java

modules/spatial-extras/build.gradle

modules/spatial-extras/src/main/java/org/elasticsearch/spatial/SpatialExtrasPlugin.java

nknize · 2020-03-18T20:19:47Z

@elasticmachine update branch

elasticmachine · 2020-03-18T20:19:49Z

merge conflict between base and head

talevy · 2020-03-31T23:23:40Z

thanks for pushing those changes to the branch @nknize, I'll get the CI happy from here on out!

rjernst

LGTM! It will be nice to have a place where we can actually start migrating geo stuff into a module.

talevy · 2020-04-07T19:26:58Z

thanks Ryan!

) (#54924) This commit introduces a new `geo` module that is intended to be contain all the geo-spatial-specific features in server. As a first step, the responsibility of registering the geo_shape field mapper is moved to this module. Co-authored-by: Nicholas Knize <nknize@gmail.com>

…3562) This commit introduces a new `geo` module that is intended to be contain all the geo-spatial-specific features in server. As a first step, the responsibility of registering the geo_shape field mapper is moved to this module. Co-authored-by: Nicholas Knize <nknize@gmail.com>

After elastic#53562, the `geo_shape` field mapper is registered within a module. This opens the door for introducing a new `geo_shape` field mapper into the Spatial Plugin that has doc-values support. This is very much an extension of server's GeoShapeFieldMapper, but with the addition of the doc values implementation.

After #53562, the `geo_shape` field mapper is registered within a module. This opens the door for introducing a new `geo_shape` field mapper into the Spatial Plugin that has doc-values support. This is very much an extension of server's GeoShapeFieldMapper, but with the addition of the doc values implementation.

…3562) This commit introduces a new `geo` module that is intended to be contain all the geo-spatial-specific features in server. As a first step, the responsibility of registering the geo_shape field mapper is moved to this module. Co-authored-by: Nicholas Knize <nknize@gmail.com>

…#55037) After elastic#53562, the `geo_shape` field mapper is registered within a module. This opens the door for introducing a new `geo_shape` field mapper into the Spatial Plugin that has doc-values support. This is very much an extension of server's GeoShapeFieldMapper, but with the addition of the doc values implementation.

…#55500) After #53562, the `geo_shape` field mapper is registered within a module. This opens the door for introducing a new `geo_shape` field mapper into the Spatial Plugin that has doc-values support. This is very much an extension of server's GeoShapeFieldMapper, but with the addition of the doc values implementation.

talevy added :Analytics/Geo Indexing, search aggregations of geo points and shapes >refactoring labels Mar 13, 2020

talevy requested review from rjernst and nknize March 13, 2020 20:23

talevy added 3 commits March 13, 2020 13:43

cover more test cases and take ownership of exists yaml tests

fe11a26

more tests

fae51f5

more fixes

e7d8efd

talevy commented Mar 13, 2020

View reviewed changes

talevy added 3 commits March 13, 2020 15:38

fix enrich test

ff1024d

add empty unit tests

99d4240

add license header

3d9fb12

rjernst reviewed Mar 13, 2020

View reviewed changes

talevy and others added 4 commits March 13, 2020 16:21

moar

136a2cf

singletonmap

d7f2279

List.of -> Arrays.asList

ad4a4bd

refactor spatial-extras to geo

c954df7

nknize and others added 5 commits March 18, 2020 15:25

Merge branch 'master' into spatial-extras

f6d68f6

spotless apply

3daf046

added TestGeoShapeFieldMapperPlugin to PinnedQueryBuilderTests

e45d92c

Merge remote-tracking branch 'elastic/master' into spatial-extras

e93f6a0

fix checkstyle

4329d0e

talevy changed the title ~~Create new spatial-extras module and migrate geo_shape registration~~ Create new geo module and migrate geo_shape registration Mar 31, 2020

talevy added 3 commits March 31, 2020 16:41

fix percolator query test

40ce9d7

Merge remote-tracking branch 'elastic/master' into spatial-extras

508b175

try to make Percolator test happy

64c0bea

rjernst approved these changes Apr 7, 2020

View reviewed changes

talevy merged commit cf9603c into elastic:master Apr 7, 2020

talevy deleted the spatial-extras branch April 7, 2020 19:27

talevy added v8.0.0 backport pending v7.8.0 labels Apr 7, 2020

talevy mentioned this pull request Apr 7, 2020

[7.x] Create new geo module and migrate geo_shape registration (#53562) #54924

Merged

talevy removed the backport pending label Apr 7, 2020

talevy mentioned this pull request Apr 9, 2020

Add geo_shape mapper supporting doc-values in Spatial Plugin #55037

Merged

talevy mentioned this pull request Apr 20, 2020

[backport] Add geo_shape mapper supporting doc-values in Spatial Plugin (#55037) #55500

Merged

talevy mentioned this pull request Apr 29, 2020

Doc values support for geo shapes. #37206

Closed

nknize mentioned this pull request May 11, 2020

Override doc_values parameter in Spatial XPack Module #53263

Closed

russcam mentioned this pull request May 29, 2020

7.8.0 Meta ticket elastic/elasticsearch-net#4718

Closed

17 tasks

jakelandis added v8.0.0-alpha1 and removed v8.0.0 labels Jul 26, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create new `geo` module and migrate geo_shape registration #53562

Create new `geo` module and migrate geo_shape registration #53562

talevy commented Mar 13, 2020 •

edited by nik9000

elasticmachine commented Mar 13, 2020

talevy Mar 13, 2020

rjernst left a comment

nknize commented Mar 18, 2020

elasticmachine commented Mar 18, 2020

talevy commented Mar 31, 2020

rjernst left a comment

talevy commented Apr 7, 2020

Create new geo module and migrate geo_shape registration #53562

Create new geo module and migrate geo_shape registration #53562

Conversation

talevy commented Mar 13, 2020 • edited by nik9000

elasticmachine commented Mar 13, 2020

talevy Mar 13, 2020

Choose a reason for hiding this comment

rjernst left a comment

Choose a reason for hiding this comment

nknize commented Mar 18, 2020

elasticmachine commented Mar 18, 2020

talevy commented Mar 31, 2020

rjernst left a comment

Choose a reason for hiding this comment

talevy commented Apr 7, 2020

Create new `geo` module and migrate geo_shape registration #53562

Create new `geo` module and migrate geo_shape registration #53562

talevy commented Mar 13, 2020 •

edited by nik9000