-
Notifications
You must be signed in to change notification settings - Fork 24.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce aarch64 packaging #53914
Introduce aarch64 packaging #53914
Conversation
This commit introduces aarch64 packaging, including bundling an aarch64 JDK distribution. We had to make some interesting choices here: - ML binaries are not compiled for aarch64, so for now we disable ML on aarch64 by default - depending on underlying page sizes, we have to disable class data sharing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Boy, just shows how much boilerplate is involved here. There's probably room for improvement there but luckily we don't add new distribution types very often. LGTM 👍
FYI, we'll need to adapt the DistributionDownloadPlugin
to the notion of an architecture as well once we want to start testing.
x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/XPackSettings.java
Show resolved
Hide resolved
This commit introduces aarch64 packaging, including bundling an aarch64 JDK distribution. We had to make some interesting choices here: - ML binaries are not compiled for aarch64, so for now we disable ML on aarch64 - depending on underlying page sizes, we have to disable class data sharing
This commit introduces aarch64 packaging, including bundling an aarch64 JDK distribution. We had to make some interesting choices here: - ML binaries are not compiled for aarch64, so for now we disable ML on aarch64 - depending on underlying page sizes, we have to disable class data sharing
archiveClassifier = 'linux-x86_64' | ||
with archiveFiles(modulesFiles(true, 'linux'), 'tar', 'linux', 'x64', true, true) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copy/paste error? I think these should be aarch64
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed 80c24a0 directly to address this. Thanks for noticing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the archiveClassifier
also need to be updated? I thought it would be linux-aarch64
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again. 🤦♀
I pushed ba431a0.
There is also the native controller to consider.
It looks like the process is launched then dies immediately. There will be no sign of this in the logs as no code will try to connect to the controller because Perhaps extend the property in |
@davidkyle The spawner today has support for architectures, and skips trying to fork the native controller when it doesn't exist: elasticsearch/server/src/main/java/org/elasticsearch/plugins/Platforms.java Lines 50 to 54 in 91462ee
elasticsearch/server/src/main/java/org/elasticsearch/bootstrap/Spawner.java Lines 75 to 78 in 91462ee
This means that when run on |
👍 thanks for the explanation @jasontedor |
This commit introduces aarch64 packaging, including bundling an aarch64 JDK distribution. We had to make some interesting choices here: