Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review status code caused by SAML exceptions #57331

Open
ywangd opened this issue May 29, 2020 · 1 comment
Open

Review status code caused by SAML exceptions #57331

ywangd opened this issue May 29, 2020 · 1 comment
Labels
>enhancement :Security/Authentication Logging in, Usernames/passwords, Realms (Native/LDAP/AD/SAML/PKI/etc) Team:Security Meta label for security team

Comments

@ywangd
Copy link
Member

ywangd commented May 29, 2020

The methodSamlUtils#samlException(String msg, Object... args) is used to signify a SAML exception in many places. A large part of this exception is catched in SamlRealm#authenticate, where it is handled internally and not exposed directly to users.

There are however usages in many other places where this exception gets ultimately translated into a 500 status code, which does not always suitable. For example, when a SAML Request is not signed, it feels more appropriate to return 400. This issue proposes to review these usages and rationalise the status code in case of error.

@ywangd ywangd added >enhancement :Security/Authentication Logging in, Usernames/passwords, Realms (Native/LDAP/AD/SAML/PKI/etc) labels May 29, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-security (:Security/Authentication)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>enhancement :Security/Authentication Logging in, Usernames/passwords, Realms (Native/LDAP/AD/SAML/PKI/etc) Team:Security Meta label for security team
Projects
None yet
Development

No branches or pull requests

2 participants