Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restrict default field name length #58952

Open
henningandersen opened this issue Jul 2, 2020 · 5 comments
Open

Restrict default field name length #58952

henningandersen opened this issue Jul 2, 2020 · 5 comments
Labels
>enhancement :Search Foundations/Mapping Index mappings, including merging and defining field types Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch

Comments

@henningandersen
Copy link
Contributor

henningandersen commented Jul 2, 2020 •
edited
Loading

The default field name length limit is unbounded. This imposes a risk to cluster health in that if a client generates wildly long field names, the resulting mapping can become large, causing cluster wide issues.

We propose to lower the default limit of field names to 10K characters. This should be done in both 8.0 and 7.x, with an opt out option.

This should only apply to field mappings created after an upgrade to a version with the new default limit.

Related to #40309
@henningandersen henningandersen added >bug :Search Foundations/Mapping Index mappings, including merging and defining field types v8.0.0 v7.9.0 needs:triage Requires assignment of a team area label labels Jul 2, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (:Search/Mapping)

@elasticmachine elasticmachine added the Team:Search Meta label for search team label Jul 2, 2020
@jimczi jimczi added team-discuss >enhancement and removed needs:triage Requires assignment of a team area label >bug labels Jul 2, 2020
@Leaf-Lin Leaf-Lin mentioned this issue Aug 4, 2020
Closed
@markharwood
Copy link
Contributor

We discussed this in the es-search meeting and had the following observations:

  • 10k is much too large for a limit
  • this limit should apply to new indices only
  • it's unclear if the limit should be on individual JSON field names or on the cumulate full path name caused by nested objects. (Nesting has a limit of 20 objects so we are looking at max 20x multiplier)

@arteam arteam added v8.1.0 and removed v8.0.0 labels Jan 12, 2022
@mark-vieira mark-vieira added v8.2.0 and removed v8.1.0 labels Feb 2, 2022
@Leaf-Lin
Copy link
Contributor

Is there an update in this issue?

@mark-vieira mark-vieira added v8.5.0 and removed v8.4.0 labels Jul 27, 2022
@csoulios csoulios added v8.6.0 and removed v8.5.0 labels Sep 21, 2022
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

@javanna javanna added Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch and removed Team:Search Meta label for search team labels Jul 16, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-foundations (Team:Search Foundations)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
>enhancement :Search Foundations/Mapping Index mappings, including merging and defining field types Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests