-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ICU Analyzer Documentation #59305
Conversation
💚 CLA has been signed |
I signed a CLA Agreement twice, once when making the PR and once when pinged by the bot. How can I remove the failing check? EDIT: Looks like commenting seems to have fixed the problem. |
@elasticmachine test this please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a straight typo when I added the docs, LGTM and thanks for fixing!
Thank you for merging! Hopefully this helps someone else out. |
I was testing the
icu_analyzer
for a project I was working on, and was very confused why it was folding diacritical marks as well, so I read the source here, and it seems theicu_analyzer
uses theICUFoldingFilter
which corresponds to theicu_folding
token filter.This PR fixes the documentation so that others don't fall into the same trap I did.