Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QL: verify that filtering's condition is always valid #66254

Closed
bpintea opened this issue Dec 14, 2020 · 1 comment · Fixed by #66268
Closed

QL: verify that filtering's condition is always valid #66254

bpintea opened this issue Dec 14, 2020 · 1 comment · Fixed by #66268
Labels
:Analytics/SQL SQL querying >bug Team:QL (Deprecated) Meta label for query languages team

Comments

@bpintea
Copy link
Contributor

bpintea commented Dec 14, 2020

A query filtering may correctly be specified with WHERE field, it's syntactically allowed.
Once #65579 is addressed, this will work with a boolean field, but with another field type, a translation error is going to be returned. This could however be caught earlier in the verifier and the proper error message returned to the user.
@elasticmachine elasticmachine added the Team:QL (Deprecated) Meta label for query languages team label Dec 14, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-ql (Team:QL)

@bpintea bpintea changed the title QL: verify that the filtering is always based on a condition QL: verify that filtering's condition is always valid Dec 14, 2020
@bpintea bpintea mentioned this issue Dec 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
:Analytics/SQL SQL querying >bug Team:QL (Deprecated) Meta label for query languages team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

QL: Verify filter's condition type bpintea/elasticsearch
2 participants
@bpintea @elasticmachine