Warn of change of default of wait_for_active_shards #67246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 7.x the close indices API defaults to `?wait_for_active_shards=0` but from 8.0 it will default to respecting the index settings instead. This commit introduces the `index-setting` value for this parameter on this API allowing users to opt-in to the future behaviour today, and starts to emit a deprecation warning for users that use the default. Relates elastic#67158 Closes elastic#66419
DaveCTurner
added
>deprecation
:Distributed/Distributed
|
Pinging @elastic/es-distributed (Team:Distributed) |
tlrx
previously approved these changes
Jan 11, 2021
|
Sorry about all the iterations here @tlrx, |
…efault-for-close-index-7x-WIP
…-close-index-7x-WIP' into 2021-01-11-deprecate-wait_for_active_shards-default-for-close-index-7x
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Jan 12, 2021
Some changes for `master` that make elastic#67246 a bit easier. Relates elastic#67158
|
Ok this is good for another look now, sorry again for all the extra noise. |
DaveCTurner
dismissed
tlrx’s stale review
substantial changes since this approval
DaveCTurner
added a commit
that referenced
this pull request
Jan 13, 2021
DaveCTurner
deleted the
2021-01-11-deprecate-wait_for_active_shards-default-for-close-index-7x
branch
DaveCTurner
added a commit
that referenced
this pull request
Jan 13, 2021
This reverts commit 8660e8d.
|
😭 in 11381c3 I have reverted this because it causes |
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Jan 14, 2021
Part of the fixes for elastic#66419, this commit permits nodes to emit the deprecation warning regarding not specifying `?wait_for_active_shards` when closing an index in 7.x versions for x ≥ 12. This change is required on `master` too since the BWC tests encounter these warnings. Relates elastic#67246, which is the 7.x part of this change.
DaveCTurner
added a commit
that referenced
this pull request
Jan 14, 2021
Part of the fixes for #66419, this commit permits nodes to emit the deprecation warning regarding not specifying `?wait_for_active_shards` when closing an index in 7.x versions for x ≥ 12. This change is required on `master` too since the BWC tests encounter these warnings. Relates #67246, which is the 7.x part of this change.
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Jan 14, 2021
In 7.x the close indices API defaults to `?wait_for_active_shards=0` but from 8.0 it will default to respecting the index settings instead. This commit introduces the `index-setting` value for this parameter on this API allowing users to opt-in to the future behaviour today, and starts to emit a deprecation warning for users that use the default. Relates elastic#67158 Retry of elastic#67246 now that elastic#67498 is merged to `master` Closes elastic#66419
|
I have opened #67527 to undo the revert and reinstate this commit. |
DaveCTurner
added a commit
that referenced
this pull request
Jan 14, 2021
In 7.x the close indices API defaults to `?wait_for_active_shards=0` but from 8.0 it will default to respecting the index settings instead. This commit introduces the `index-setting` value for this parameter on this API allowing users to opt-in to the future behaviour today, and starts to emit a deprecation warning for users that use the default. Relates #67158 Retry of #67246 now that #67498 is merged to `master` Closes #66419
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 7.x the close indices API defaults to
?wait_for_active_shards=0butfrom 8.0 it will default to respecting the index settings instead. This
commit introduces the
index-settingvalue for this parameter on thisAPI allowing users to opt-in to the future behaviour today, and starts
to emit a deprecation warning for users that use the default.
Relates #67158
Closes #66419