Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce default max content-length #67804

Open
Tim-Brooks opened this issue Jan 21, 2021 · 3 comments
Open

Reduce default max content-length #67804

Tim-Brooks opened this issue Jan 21, 2021 · 3 comments
Labels
:Distributed/Network Http and internode communication implementations >enhancement Team:Distributed Meta label for distributed team

Comments

@Tim-Brooks
Copy link
Contributor

By default Elasticsearch supports a content-length of 100MB at the http layer. This default suggests that this is an appropriate size for bulk requests. 100MB is certainly much larger than necessary in order to achieve improved performance through reduced round trips and combined FSYNCs. Additionally, 100MB probably crosses the threshold, where performance is harmed due to the fact the content is not currently incrementally circuit broken and we probably do not handle that size of memory very effectively.

We should consider reducing this default to something more reasonable (8-32MB?). This is a static setting, so it would require clear release notes for 100MB users to reconfigure at rolling restart. Or it would need work to make it a dynamic setting (tricky).

@Tim-Brooks Tim-Brooks added >enhancement :Distributed/Network Http and internode communication implementations team-discuss labels Jan 21, 2021
@elasticmachine elasticmachine added the Team:Distributed Meta label for distributed team label Jan 21, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

@original-brownbear
Copy link
Member

@tbrooks8 do you still remember what we concluded needs to be done here?

@Tim-Brooks
Copy link
Contributor Author

We discussed and decided not to take immediate action. I think we were in a agreement that 100MB bulk requests is larger than we would like. But making this change might need (if we did) would need to be coordinated with clients.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed/Network Http and internode communication implementations >enhancement Team:Distributed Meta label for distributed team
Projects
None yet
Development

No branches or pull requests

3 participants