Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow node shutdowns to change types from "restart" to "remove" #71305

Open
gwbrown opened this issue Apr 5, 2021 · 2 comments
Open

Allow node shutdowns to change types from "restart" to "remove" #71305

gwbrown opened this issue Apr 5, 2021 · 2 comments
Labels
:Core/Infra/Node Lifecycle Node startup, bootstrapping, and shutdown Team:Core/Infra Meta label for core/infra team

Comments

@gwbrown
Copy link
Contributor

gwbrown commented Apr 5, 2021

As of #71162, node shutdowns can be requested, but cannot be updated by the user after initial creation.

It would be useful if a shutdown could be updated from type RESTART to REMOVAL if the decision is changed partway through shutdown. I don't believe there's anything blocking us from allowing that, beyond updating the API to allow it.

Relates #70338

@gwbrown gwbrown added the :Core/Infra/Node Lifecycle Node startup, bootstrapping, and shutdown label Apr 5, 2021
@elasticmachine elasticmachine added the Team:Core/Infra Meta label for core/infra team label Apr 5, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@sebgl
Copy link

sebgl commented May 4, 2021

I'm wondering about the following use case: long-term, I want to remove a node, so I scheduled a shutdown (removal type).
Short-term: something happened that requires me to restart that same node. This could be anything, but specifically I'm wondering if there are cases where the restart could help the removal (data migration) to go through. For example if that instance suffers from high memory pressure?

Can I turn the removal to a restart? Does it require me to re-request a removal once the restart is done?

From my perspective, those two operations could be decoupled. I want to eventually remove the node (long data migration involved), but right now I need to restart it. The restart intent doesn't change the fact I still want data to be migrated away from the node.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Core/Infra/Node Lifecycle Node startup, bootstrapping, and shutdown Team:Core/Infra Meta label for core/infra team
Projects
None yet
Development

No branches or pull requests

3 participants