It is possible to index a document that contains two discrete JSON objects

[polyfractal]

This is most noticeable with bulk requests because of the bulk format. Since the newline is used as a separator, omitting a newline will index a document that contains two JSON objects. The first JSON object is indexed properly, while the second is completely ignored (not found in the mapping, etc).

However, this causes problems with source retrieval, search, GET, etc because the JSON is invalid.

There should either be an error returned when trying to index a document containing two (or more) discrete objects, or the non-indexed objects should be removed from the source. The exception seems preferable so the user knows something went wrong.

Reproduction (Bulk):

curl -XPOST "http://localhost:9200/cars/transactions/_bulk" -d'
{ "index": {"_id":1}}
{ "price" : 10000, "color" : "red", "make" : "honda", "sold" : "2014-10-28" }{ "index": {"_id":2}}
{ "price" : 20000, "color" : "red", "make" : "honda", "sold" : "2014-11-05" }
{ "index": {"_id":3}}
{ "price" : 30000, "color" : "green", "make" : "ford", "sold" : "2014-05-18" }
'

{
   "took": 72,
   "errors": false,
   "items": [
      {
         "index": {
            "_index": "cars",
            "_type": "transactions",
            "_id": "1",
            "_version": 1,
            "status": 201
         }
      }
   ]
}

curl -XGET "http://localhost:9200/cars/transactions/1"

{
   "_index":"cars",
   "_type":"transactions",
   "_id":"1",
   "_version":1,
   "found":true,
   "_source":{
      "price":10000,
      "color":"red",
      "make":"honda",
      "sold":"2014-10-28"
   }   {
      "index":{
         "_id":2
      }
   }
}

Reproduction (Single Doc):

curl -XPOST "http://localhost:9200/cars/transactions/5" -d'
{ "price" : 10000, "color" : "red", "make" : "honda", "sold" : "2014-10-28" }{ "index": {"_id":2}}'

{
   "_index": "cars",
   "_type": "transactions",
   "_id": "5",
   "_version": 1,
   "created": true
}

curl -XGET "http://localhost:9200/cars/transactions/5"

{
   "_index":"cars",
   "_type":"transactions",
   "_id":"5",
   "_version":1,
   "found":true,
   "_source":{
      "price":10000,
      "color":"red",
      "make":"honda",
      "sold":"2014-10-28"
   }   {
      "index":{
         "_id":2
      }
   }
}

[clintongormley]

This will probably be fixed by #2315

[polyfractal]

Closing this, resolved by #11414. If you attempt to index a "double" JSON object, ES throws an exception up-front now instead of silently accepting it:

{
   "error": {
      "root_cause": [
         {
            "type": "illegal_argument_exception",
            "reason": "Malformed action/metadata line [3], expected START_OBJECT or END_OBJECT but found [VALUE_NUMBER]"
         }
      ],
      "type": "illegal_argument_exception",
      "reason": "Malformed action/metadata line [3], expected START_OBJECT or END_OBJECT but found [VALUE_NUMBER]"
   },
   "status": 400
}