Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] excludeDeleting option of JobConfigProvider.expandJobs and JobConfigProvider.expandJobsIds leads to unintuitive error messages #74548

Open
droberts195 opened this issue Jun 24, 2021 · 1 comment
Labels
>bug :ml Machine learning Team:ML Meta label for the ML team

Comments

@droberts195
Copy link
Contributor

The JobConfigProvider.expandJobs and JobConfigProvider.expandJobIds methods have an excludeDeleting argument that excludes deleting jobs from the returned list.

This method is then used in most of our endpoints that accept wildcarded job ID patterns, so that, for example, you cannot close a job that is being deleted.

However, the downside of the way this works is that if you call one of these endpoints against a job that is being deleted you will be told that the job doesn't exist. This is extremely confusing.

For example, if you try to close a job that is being deleted, you'll receive a resource not found exception. This is inconsistent with the decision we made that closing a closed job is not an error. In the case of a job whose deletion is proving problematic for some other reason it also makes troubleshooting harder, because the output from one request may lead the people doing the troubleshooting to think the job no longer exists (i.e. the desired state) when it still does exist but is stuck in the deleting state.

@droberts195 droberts195 added >bug :ml Machine learning labels Jun 24, 2021
@elasticmachine elasticmachine added the Team:ML Meta label for the ML team label Jun 24, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug :ml Machine learning Team:ML Meta label for the ML team
Projects
None yet
Development

No branches or pull requests

2 participants